-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhanced functionality to improve developer experience by identifying… #7494
base: main
Are you sure you want to change the base?
Enhanced functionality to improve developer experience by identifying… #7494
Conversation
… parent packages or projects from duplicate packages. This commit introduces new features that parse the dependency graph, starting from the duplicate package and ending at the parent package/project that encompasses it. Signed-off-by: iliou <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
detekt found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.
Thanks or the contribution @dimitris-iliou. But before you put too much effort in it, be informed that during one of the last ORT community meetings it was agreed that the best solution to address the issue is to not have duplicate IDs between project and packages to begin with, and deduplicate these by replacing references with package linkage in the dependency tree by references that link to the project instead. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7494 +/- ##
=========================================
Coverage 68.01% 68.01%
Complexity 2023 2023
=========================================
Files 339 339
Lines 16719 16719
Branches 2371 2371
=========================================
Hits 11371 11371
Misses 4363 4363
Partials 985 985
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@sschuberth : How might multiple subdirectories with the same python package dependencies within each
from this TODO ort/analyzer/src/main/kotlin/AnalyzerResultBuilder.kt Lines 57 to 58 in 956d12e
causing this exception ort/analyzer/src/main/kotlin/AnalyzerResultBuilder.kt Lines 46 to 47 in 956d12e
For example:
|
… parent packages or projects from duplicate packages. This commit introduces new features that parse the dependency graph, starting from the duplicate package and ending at the parent package/project that encompasses it.
#6465